Skip to content

Comments

fix: non-existent field access on error message#577

Merged
barnabasbusa merged 2 commits intoethpandaops:mainfrom
lambdaclass:fix-no-name-field
Apr 26, 2024
Merged

fix: non-existent field access on error message#577
barnabasbusa merged 2 commits intoethpandaops:mainfrom
lambdaclass:fix-no-name-field

Conversation

@MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Apr 25, 2024 •
edited
Loading

Fixes #576

Now it correctly results in the error message:

There was an error interpreting Starlark code 
Evaluation error: fail: Unsupported launcher 'foo', need one of 'lighthouse,lodestar,nimbus,prysm,teku,grandine'
        at [github.com/kurtosis-tech/ethereum-package/main.star:104:55]: run
        at [github.com/kurtosis-tech/ethereum-package/src/participant_network.star:166:34]: launch_participant_network
        at [github.com/kurtosis-tech/ethereum-package/src/cl/cl_launcher.star:106:17]: launch
        at [0:0]: fail

Error encountered running Starlark code.

@barnabasbusa
Copy link
Collaborator

barnabasbusa commented Apr 25, 2024

I’m sorry but why is “ Unsupported launcher 'foo', need one of 'lighthouse, lodestar, nimbus, prysm, teku, grandine'” not a sufficient error message? What CL client are you launching with your node?

@MegaRedHand
Copy link
Contributor Author

MegaRedHand commented Apr 25, 2024

There's some context in #576. I was working on integrating https://github.com/lambdaclass/lambda_ethereum_consensus with this repo and found the bug when first adding our client to the args file: "Unsupported launcher ..." wasn't being printed, but an internal error because of outdated code (each client entry had a name attribute before, but they no longer do).

@barnabasbusa
Copy link
Collaborator

barnabasbusa commented Apr 26, 2024

Ah got it, good catch thanks!

@barnabasbusa barnabasbusa enabled auto-merge (squash) April 26, 2024 16:00
@barnabasbusa
Copy link
Collaborator

barnabasbusa commented Apr 26, 2024

Could you please update your branch with the latest main?

@MegaRedHand
Copy link
Contributor Author

MegaRedHand commented Apr 26, 2024

Done!

@barnabasbusa barnabasbusa merged commit 8515d27 into ethpandaops:main Apr 26, 2024
@github-actions github-actions bot mentioned this pull request Apr 26, 2024
Merged
@MegaRedHand MegaRedHand deleted the fix-no-name-field branch April 26, 2024 17:42
barnabasbusa pushed a commit that referenced this pull request May 6, 2024
@github-actions
chore(main): release 3.0.0 (#574)
9062edd 
🤖 I have created a release *beep* *boop*
---


##
[3.0.0](2.2.0...3.0.0)
(2024-05-06)


### ⚠ BREAKING CHANGES

* add mev-rs relay/builder/boost
([#586](#586))
* upcoming file path change in kurtosis upstream
([#582](#582))

### Features

* add apache file server
([#581](#581))
([205256a](205256a))
* add enr/enode to apache
([#589](#589))
([b789e17](b789e17))
* add execution client urls to dora config
([#588](#588))
([2a20d5a](2a20d5a))
* add mev-rs relay/builder/boost
([#586](#586))
([525a8fb](525a8fb))
* Add peerdas support
([#591](#591))
([14296ca](14296ca))
* add snooper urls to assertoor config
([#571](#571))
([87f383f](87f383f))
* allow setting exit ip address
([#584](#584))
([aabc942](aabc942))


### Bug Fixes

* non-existent field access on error message
([#577](#577))
([8515d27](8515d27))
* participant redefining global flag
([#573](#573))
([9139f4b](9139f4b))
* path for shadowforks post kt update
([#585](#585))
([e0622a7](e0622a7))
* remove erigon's --chain parameter
([#575](#575))
([02b9c50](02b9c50))
* upcoming file path change in kurtosis upstream
([#582](#582))
([8d7c4f9](8d7c4f9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
darigaaz86 pushed a commit to darigaaz86/kurtosis-eth that referenced this pull request Nov 12, 2025
@github-actions
chore(main): release 3.0.0 (#574)
a3e386e 
🤖 I have created a release *beep* *boop*
---


##
[3.0.0](ethpandaops/ethereum-package@2.2.0...3.0.0)
(2024-05-06)


### ⚠ BREAKING CHANGES

* add mev-rs relay/builder/boost
([#586](ethpandaops/ethereum-package#586))
* upcoming file path change in kurtosis upstream
([#582](ethpandaops/ethereum-package#582))

### Features

* add apache file server
([#581](ethpandaops/ethereum-package#581))
([205256a](ethpandaops/ethereum-package@205256a))
* add enr/enode to apache
([#589](ethpandaops/ethereum-package#589))
([b789e17](ethpandaops/ethereum-package@b789e17))
* add execution client urls to dora config
([#588](ethpandaops/ethereum-package#588))
([2a20d5a](ethpandaops/ethereum-package@2a20d5a))
* add mev-rs relay/builder/boost
([#586](ethpandaops/ethereum-package#586))
([525a8fb](ethpandaops/ethereum-package@525a8fb))
* Add peerdas support
([#591](ethpandaops/ethereum-package#591))
([14296ca](ethpandaops/ethereum-package@14296ca))
* add snooper urls to assertoor config
([#571](ethpandaops/ethereum-package#571))
([87f383f](ethpandaops/ethereum-package@87f383f))
* allow setting exit ip address
([#584](ethpandaops/ethereum-package#584))
([aabc942](ethpandaops/ethereum-package@aabc942))


### Bug Fixes

* non-existent field access on error message
([#577](ethpandaops/ethereum-package#577))
([8515d27](ethpandaops/ethereum-package@8515d27))
* participant redefining global flag
([#573](ethpandaops/ethereum-package#573))
([9139f4b](ethpandaops/ethereum-package@9139f4b))
* path for shadowforks post kt update
([#585](ethpandaops/ethereum-package#585))
([e0622a7](ethpandaops/ethereum-package@e0622a7))
* remove erigon's --chain parameter
([#575](ethpandaops/ethereum-package#575))
([02b9c50](ethpandaops/ethereum-package@02b9c50))
* upcoming file path change in kurtosis upstream
([#582](ethpandaops/ethereum-package#582))
([8d7c4f9](ethpandaops/ethereum-package@8d7c4f9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barnabasbusa barnabasbusa barnabasbusa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"String has no .name field or method" when using unsupported CL client

2 participants

@MegaRedHand @barnabasbusa