simulators/ethereum/graphql/testcases: change block number input to number instead of hexadecimal#445
Merged
holiman merged 4 commits intoethereum:masterfrom Feb 26, 2021
Conversation
renaynay
force-pushed
the
fix_blockByNumber_graphql
branch
from
1a4304f to
9f4d829
Compare
holiman
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the following test cases to use number instead of hexadecimal as the input parameter for block number:
02_eth_call_Block816_eth_getBlock_byNumber20_eth_getBlockTransactionCount_byNumber23_eth_getLogs_matchTopic28_eth_getTransaction_byBlockNumberAndIndex29_eth_getTransaction_byBlockNumberAndInvalidIndexWith this PR, geth no longer accepts strings for the block number parameter. Besu accepts both.
Additionally, I added an additional valid response for
17_eth_getBlock_byNumberInvalid, but it is still failing as there is a discrepancy in error reporting between Besu and Geth (discussed here) that will hopefully be solved soon.