simulators/ethereum/graphql: change account queries to be on block, not account#426
Merged
holiman merged 2 commits intoethereum:masterfrom Mar 12, 2021
Merged
Conversation
99c44ec to
46b58ca
Compare
Collaborator
|
I don't fully understand which queries are unsupported. Do you mean The JSON-RPC compatibility table in EIP-1767 contains this row: So I guess this query should be supported? |
Contributor
Author
|
It was never required by the graphql spec though and we don't have it implemented. Should we implement support for queries on account then in geth? |
Collaborator
|
We talked about this in a call and decided couple things:
|
Contributor
Author
|
Account exception was removed in Besu and status code returned is now 200, after fixing merge conflicts and removing the option for multiple status codes, can we merge this? |
0b7e0c0 to
d71de1a
Compare
Contributor
|
Oh, did I merge them in wrong order? Now there are conflicts (oops) |
Contributor
Author
|
Yes, but it's okay :) I can fix them, thanks @holiman |
8689e2e to
ccb1426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes several testcases from querying on account to querying on block for account information. Queries on account are not required by the graphql spec. While Besu implements queries on account, geth does not as it is not required.