Skip to content

internal/libhive: skip unsuccessful build of client #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjl merged 1 commit into from
Aug 20, 2024
Merged

internal/libhive: skip unsuccessful build of client #1154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/libhive/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (r *Runner) buildClients(ctx context.Context, clientList []ClientDesignator
return errors.New("client list is empty, cannot simulate")
}

r.clientDefs = make([]*ClientDefinition, len(clientList))
r.clientDefs = make([]*ClientDefinition, 0, len(clientList))

var anyBuilt bool
log15.Info(fmt.Sprintf("building %d clients...", len(clientList)))
Expand All @@ -72,12 +72,12 @@ func (r *Runner) buildClients(ctx context.Context, clientList []ClientDesignator
if err != nil {
log15.Warn("can't read version info of "+client.Client, "image", image, "err", err)
}
r.clientDefs[i] = &ClientDefinition{
r.clientDefs = append(r.clientDefs, &ClientDefinition{
Name: client.Name(),
Version: strings.TrimSpace(string(version)),
Image: image,
Meta: r.inv.Clients[client.Client].Meta,
}
})
}
if !anyBuilt {
return errors.New("all clients failed to build")
Expand Down