Skip to content

Conversation

@s1na
Copy link
Contributor

@s1na s1na commented Aug 20, 2024

To reproduce the issue, set this clients definition:

- client: go-ethereum
  nametag: multicall-git
  dockerfile: git
  build_args:
    github: s1na/go-ethereum
    tag: multicall

- client: nethermind
  nametag: multicall-git
  dockerfile: git
  build_args:
    github: NethermindEth/nethermind
    tag: feature/eth_simulate_fix

The branch feature/eth_simulate_fix has been removed from the nethermind repo. This causes the container build to fail:

Cloning: NethermindEth/nethermind - feature/eth_simulate_fix
Cloning into 'nethermind'...
fatal: Remote branch feature/eth_simulate_fix not found in upstream origin
EROR[08-20|11:49:12] image build failed                       image=hive/clients/nethermind_multicall-git:latest err="The command '/bin/sh -c echo \"Cloning: $github - $tag\" &&     git clone -b $tag https://github.com/$github &&     cd /nethermind/src/Nethermind/Nethermind.Runner &&     dotnet build -c release' returned a non-zero code: 128"

However hive still tries to run the simulation against that client and crashes:

[a3bf5ee8] panic: runtime error: invalid memory address or nil pointer dereference
[a3bf5ee8] [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x6a3508]
[a3bf5ee8] 
[a3bf5ee8] goroutine 1 [running]:
[a3bf5ee8] github.com/ethereum/hive/hivesim.(*ClientDefinition).HasRole(...)
[a3bf5ee8]      /go/pkg/mod/github.com/ethereum/[email protected]/hivesim/data.go:45
[a3bf5ee8] github.com/ethereum/hive/hivesim.ClientTestSpec.runTest({{0x77b078, 0xd}, {0x0, 0x0}, {0x78c3b1, 0x34}, {0x0, 0x0}, 0x1, {0x778533, ...}, ...}, ...)
[a3bf5ee8]      /go/pkg/mod/github.com/ethereum/[email protected]/hivesim/testapi.go:411 +0xe8
[a3bf5ee8] github.com/ethereum/hive/hivesim.RunSuite(0x4000024440, {{0x779df5, 0xa}, {0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, {0x791159, ...}, ...})
[a3bf5ee8]      /go/pkg/mod/github.com/ethereum/[email protected]/hivesim/testapi.go:81 +0x2fc
[a3bf5ee8] github.com/ethereum/hive/hivesim.MustRunSuite(0x0?, {{0x779df5, 0xa}, {0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, {0x791159, ...}, ...})
[a3bf5ee8]      /go/pkg/mod/github.com/ethereum/[email protected]/hivesim/testapi.go:91 +0x7c
[a3bf5ee8] main.main()
[a3bf5ee8]      /source/main.go:58 +0x1e8

@fjl fjl changed the title libhive: skip unsuccessful build of client internal/libhive: skip unsuccessful build of client Aug 20, 2024
@fjl fjl merged commit e8819f1 into ethereum:master Aug 20, 2024
fedacking pushed a commit to lambdaclass/hive that referenced this pull request May 19, 2025
fedacking pushed a commit to lambdaclass/hive that referenced this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants