Skip to content

Conversation

@winsvega
Copy link
Contributor

@winsvega winsvega commented Jun 27, 2024

adds --sim.argument option to be set as env variable inside simulator dockers
this to run consensus tests on different revisions:

# run develop bc tests
./hive --sim ethereum/consensus --client go-ethereum  --sim.limit "/add11" 

# run legacy tests from constantinople fix to cancun
./hive --sim ethereum/consensus --client go-ethereum  --sim.limit "/add11"  --sim.argument "legacy-cancun"

# run legacy tests from frontier to constantinople
./hive --sim ethereum/consensus --client go-ethereum  --sim.limit "/add11"  --sim.argument "legacy"

we only need to regulaly run develop tests. and sometimes legacy tests. to save execution time.

@marioevz marioevz requested a review from fjl July 11, 2024 20:11
@winsvega
Copy link
Contributor Author

@fjl how about this way?

@fjl
Copy link
Collaborator

fjl commented Jul 13, 2024

I think what we should do is, expose the test groups as "suites", which is an existing concept in hive. Then you could run it like

# run legacy tests from constantinople fix to cancun
./hive --sim ethereum/consensus --client go-ethereum  --sim.limit "legacy-cancun/add11"

@fjl fjl changed the title consensus simulator args simulators/consensus: split test suites Jul 15, 2024
@fjl
Copy link
Collaborator

fjl commented Jul 15, 2024

I have implemented my suggestion and it works. You can select the test suites using --sim.limit.

@fjl fjl merged commit 6f37e79 into ethereum:master Jul 15, 2024
@fjl fjl changed the title simulators/consensus: split test suites simulators/ethereum/consensus: split test suites Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants