Closed
Conversation
Collaborator
|
It's not great to simply copy the consensus simulator including its implementation. We could just integrate it into the existing consensus simulator as a separate test suite. |
Contributor
Author
|
The legacy simulators should run not on a daily basis. Ideally, the logic should be abstracted out. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of copy paste, but its ok because legacy tests won't be changing.
So this adds simulators
legacy-consensus- to run all the tests we had at the times generated from Frontier to Constantinople revisionslegacy-consensus-cancun- to run all the tests from Constantinople up to Cancunand from >=Cancun and beyond the tests might change and will be migrated to Pyspecs. so the format might change.
those will be fun by
consensussimulator regulary. those tests are all vectors we have in Cancun only revision. so each run will save time.then legacy- ones could be run once a week or so. this will save hive stats the running time.