triedb/pathdb: fix layer 5 key range in storage iterator traversal test#34883
Merged
rjl493456442 merged 1 commit intoMay 11, 2026
Merged
Conversation
Mirror the account-iterator test fix from ethereum#34639 into the sibling storage-iterator test in the same file. The layer-5 diff condition used `i > 50 || i < 85`, which is true for every byte in the 0..255 loop since the two ranges cover the full byte space between them. Switch to `i > 50 && i < 85` so layer 5 only covers the intended band (51..84), consistent with the fix already applied to TestAccountIteratorTraversalValues in ethereum#34639 and to both variants of TestAccountIteratorTraversalValues / TestStorageIteratorTraversalValues in core/state/snapshot/iterator_test.go from ethereum#34638.
rjl493456442
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the account-iterator test fix from #34639 into the sibling storage-iterator test in the same file. The layer-5 diff condition used
i > 50 || i < 85, which is true for every byte in the 0..255 loop since the two ranges cover the full byte space between them.Switch to
i > 50 && i < 85so layer 5 only covers the intended band (51..84), consistent with the fix already applied to TestAccountIteratorTraversalValues in #34639 and to both variants of TestAccountIteratorTraversalValues / TestStorageIteratorTraversalValues in core/state/snapshot/iterator_test.go from #34638.