Skip to content

core/state/snapshot: fix condition in iterator traversal test#34638

Merged
s1na merged 1 commit into
ethereum:masterfrom
cuiweixie:snapshot-fix-iterator-test-layer5-range
May 1, 2026
Merged

core/state/snapshot: fix condition in iterator traversal test#34638
s1na merged 1 commit into
ethereum:masterfrom
cuiweixie:snapshot-fix-iterator-test-layer5-range

Conversation

@cuiweixie
Copy link
Copy Markdown
Contributor

The layer-5 diff condition used i > 50 || i < 85, which is true for almost all keys in the 0..255 loop. Use i > 50 && i < 85 so layer 5 only covers the intended band (51..84), matching the comment intent in the test setup.

@cuiweixie cuiweixie requested a review from rjl493456442 as a code owner April 2, 2026 15:59
Copy link
Copy Markdown
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1na s1na changed the title core/state/snapshot: fix layer 5 key range in iterator traversal tests core/state/snapshot: fix condition in iterator traversal test May 1, 2026
@s1na s1na added this to the 1.17.3 milestone May 1, 2026
@s1na s1na merged commit d270e21 into ethereum:master May 1, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants