Skip to content

internal/ethapi: add balHash to block results #34652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjl merged 1 commit into from
May 12, 2026
+3 −0
Merged

internal/ethapi: add balHash to block results #34652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/ethapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,9 @@ func RPCMarshalHeader(head *types.Header) map[string]interface{} {
if head.RequestsHash != nil {
result["requestsHash"] = head.RequestsHash
}
if head.BlockAccessListHash != nil {
Copy link
Copy Markdown
Member

@rjl493456442 rjl493456442 Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link the RPC spec? not sure the field name is "balHash"

Copy link
Copy Markdown
Contributor Author

@cuiweixie cuiweixie Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPC spec haven't add the field yet.

Copy link
Copy Markdown
Member

@rjl493456442 rjl493456442 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's on-hold this change for a while until it's explicitly defined in the spec

result["balHash"] = head.BlockAccessListHash
}
if head.SlotNumber != nil {
result["slotNumber"] = hexutil.Uint64(*head.SlotNumber)
}
Expand Down
Loading