Skip to content

internal/ethapi: add balHash to block results#34652

Merged
fjl merged 1 commit into
ethereum:masterfrom
cuiweixie:missing_BlockAccessListHash
May 12, 2026
Merged

internal/ethapi: add balHash to block results#34652
fjl merged 1 commit into
ethereum:masterfrom
cuiweixie:missing_BlockAccessListHash

Conversation

@cuiweixie
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread internal/ethapi/api.go
if head.RequestsHash != nil {
result["requestsHash"] = head.RequestsHash
}
if head.BlockAccessListHash != nil {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link the RPC spec? not sure the field name is "balHash"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPC spec haven't add the field yet.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's on-hold this change for a while until it's explicitly defined in the spec

@fjl fjl merged commit 91f8e7c into ethereum:master May 12, 2026
6 of 8 checks passed
@fjl fjl added the amsterdam label May 12, 2026
@fjl fjl added this to the 1.17.4 milestone May 12, 2026
@fjl fjl changed the title internal: add balHash internal/ethapi: add balHash to block results May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants