Skip to content

eth: fix the flaky test of TestSnapSyncDisabling68 #33896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gballet merged 1 commit into from
Feb 27, 2026
+10 −7
Merged

eth: fix the flaky test of TestSnapSyncDisabling68 #33896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions eth/sync_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,18 @@ func testSnapSyncDisabling(t *testing.T, ethVer uint, snapVer uint) {
if err := empty.handler.downloader.BeaconSync(full.chain.CurrentBlock(), nil); err != nil {
t.Fatal("sync failed:", err)
}
// Downloader internally has to wait for a timer (3s) to be expired before
// exiting. Poll after to determine if sync is disabled.
time.Sleep(time.Second * 3)
for timeout := time.After(time.Second); ; {
// Snap sync and mode switching happen asynchronously, poll for completion.
timeout := time.NewTimer(15 * time.Second)
tick := time.NewTicker(100 * time.Millisecond)
defer timeout.Stop()
defer tick.Stop()

for {
select {
case <-timeout:
case <-timeout.C:
t.Fatalf("snap sync not disabled after successful synchronisation")
case <-time.After(100 * time.Millisecond):
if empty.handler.downloader.ConfigSyncMode() == ethconfig.FullSync {
case <-tick.C:
if empty.handler.synced.Load() && empty.handler.downloader.ConfigSyncMode() == ethconfig.FullSync {
return
}
}
Expand Down