Skip to content

eth: fix the flaky test of TestSnapSyncDisabling68#33896

Merged
gballet merged 1 commit into
ethereum:masterfrom
jsvisa:fix-flaky-TestSnapSyncDisabling68
Feb 27, 2026
Merged

eth: fix the flaky test of TestSnapSyncDisabling68#33896
gballet merged 1 commit into
ethereum:masterfrom
jsvisa:fix-flaky-TestSnapSyncDisabling68

Conversation

@jsvisa
Copy link
Copy Markdown
Contributor

@jsvisa jsvisa commented Feb 26, 2026

fix the flaky test found in https://ci.appveyor.com/project/ethereum/go-ethereum/builds/53601688/job/af5ccvufpm9usq39

  1. increase the timeout from 3+1s to 15s, and use timer instead of sleep(in the CI env, it may need more time to sync the 1024 blocks)
  2. add synced.Load() to ensure the full async chain is finished

Signed-off-by: Delweng <delweng@gmail.com>
@jsvisa jsvisa requested a review from rjl493456442 as a code owner February 26, 2026 08:26
Copy link
Copy Markdown
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gballet gballet added this to the 1.17.1 milestone Feb 27, 2026
@gballet gballet merged commit cee751a into ethereum:master Feb 27, 2026
7 of 8 checks passed
@jsvisa jsvisa deleted the fix-flaky-TestSnapSyncDisabling68 branch February 28, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants