core/txpool: Optimize locks in LegacyPool#32927
Closed
KyrinCode wants to merge 3 commits intoethereum:masterfrom
Closed
core/txpool: Optimize locks in LegacyPool#32927KyrinCode wants to merge 3 commits intoethereum:masterfrom
KyrinCode wants to merge 3 commits intoethereum:masterfrom
Conversation
Changed locking mechanism in Content method to use RLock for read operations.
Member
|
Duplicated with #32924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging with OP-Stack, I found that the RWLock has severe impact on performance of packing txs during stress test, especially when there are over 400,000+ txs in the txpool. It seems these two functions just need a read lock.