Use read lock for Content, Pending, ToJournal methods#698
Closed
KyrinCode wants to merge 2 commits intoethereum-optimism:optimismfrom
Closed
Use read lock for Content, Pending, ToJournal methods#698KyrinCode wants to merge 2 commits intoethereum-optimism:optimismfrom
KyrinCode wants to merge 2 commits intoethereum-optimism:optimismfrom
Conversation
Changed mutex locking from exclusive to read-only for improved concurrency.
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
Contributor
|
Thanks but this change would be better submitted to upstream geth and then will be pulled through to op-geth as part of pulling in geth releases. We try to minimise the diff from upstream to make maintenance easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed mutex locking from exclusive to read-only for improved concurrency.
Additional context
This is the PR for upstream go-ethereum.