Skip to content

metrics: add chain/gas for cumulative gas usage #32294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seanl-circle wants to merge 1 commit into from
Closed

metrics: add chain/gas for cumulative gas usage #32294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/blockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ var (

chainInfoGauge = metrics.NewRegisteredGaugeInfo("chain/info", nil)
chainMgaspsMeter = metrics.NewRegisteredResettingTimer("chain/mgasps", nil)
chainGasCounter = metrics.NewRegisteredCounter("chain/gas/total", nil)

accountReadTimer = metrics.NewRegisteredResettingTimer("chain/account/reads", nil)
accountHashTimer = metrics.NewRegisteredResettingTimer("chain/account/hashes", nil)
Expand Down Expand Up @@ -1888,6 +1889,7 @@ func (bc *BlockChain) insertChain(chain types.Blocks, setHead bool, makeWitness
// Report the import stats before returning the various results
stats.processed++
stats.usedGas += res.usedGas
chainGasCounter.Inc(int64(res.usedGas))
Copy link
Copy Markdown
Member

@rjl493456442 rjl493456442 Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's inaccurate. Chain processing becomes idle once the initial state sync completes, so it's impossible to derive the MGas/s rate without knowing how long the processor is actively running

Copy link
Copy Markdown
Contributor Author

@seanl-circle seanl-circle Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that may be true most of the time for ethereum, we see cases in downstream forks where geth will lag for signicant periods with the processor always running.

MGas/s is uninteresting when the node can keep up, we want to know what happens when it can't.

witness = res.witness

var snapDiffItems, snapBufItems common.StorageSize
Expand Down