metrics: add chain/gas for cumulative gas usage#32294
Closed
seanl-circle wants to merge 1 commit intoethereum:masterfrom
Closed
metrics: add chain/gas for cumulative gas usage#32294seanl-circle wants to merge 1 commit intoethereum:masterfrom
seanl-circle wants to merge 1 commit intoethereum:masterfrom
Conversation
Member
|
Can’t you use chain/mgasps? It's not a gauge that only records the instantaneous value, it's a histogram. |
| // Report the import stats before returning the various results | ||
| stats.processed++ | ||
| stats.usedGas += res.usedGas | ||
| chainGasCounter.Inc(int64(res.usedGas)) |
Member
There was a problem hiding this comment.
That's inaccurate. Chain processing becomes idle once the initial state sync completes, so it's impossible to derive the MGas/s rate without knowing how long the processor is actively running
Contributor
Author
There was a problem hiding this comment.
While that may be true most of the time for ethereum, we see cases in downstream forks where geth will lag for signicant periods with the processor always running.
MGas/s is uninteresting when the node can keep up, we want to know what happens when it can't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This redoes #32004 where the new metric I wanted to add was dropped in later revisions.
The reasoning is the same as before: a gauge is only useful at the moment you observe it, but most of us will have metric systems that collect and record the data periodically out of sync with gauge updates. A total value allows us to derive accurate Mgas/s metrics over long periods.