core,miner: implement EIP-7934 - RLP Execution Block Size Limit#31990
Merged
fjl merged 25 commits intoethereum:masterfrom Jul 9, 2025
Merged
core,miner: implement EIP-7934 - RLP Execution Block Size Limit#31990fjl merged 25 commits intoethereum:masterfrom
fjl merged 25 commits intoethereum:masterfrom
Conversation
jwasinger
requested review from
MariusVanDerWijden,
fjl,
gballet,
karalabe,
rjl493456442 and
zsfelfoldi
as code owners
fjl
reviewed
Jun 9, 2025
Contributor
There was a problem hiding this comment.
Also, the block body size is also influenced by other things, such as withdrawals. So we need to add a bit of buffer into the size limit here. For the withdrawals, we may be able to add their true size into env.size before adding transactions.
Member
There was a problem hiding this comment.
From the CL team:
potuz — 2025/6/10 21:11
This makes the payload invalid
Technically it will make the consensus block that contains that payload invalid.
Probably we need to put a note here, at least adding a warning log that a part of withdrawals specified by the CL are discarded due to the size restriction. In practice, it's impossible to occur.
Contributor
Author
There was a problem hiding this comment.
This happens before we fill the block with txs. Also, max block withdrawal count is capped by the protocol.
fjl
added a commit
that referenced
this pull request
Jun 12, 2025
spencer-tb
pushed a commit
to spencer-tb/go-ethereum
that referenced
this pull request
Jun 13, 2025
fjl
added a commit
that referenced
this pull request
Jun 13, 2025
fjl
changed the title
Contributor
|
I have made two changes:
|
fjl
reviewed
Jul 9, 2025
| // The tx had a sidecar before, so we need to subtract it from the size. | ||
| scSize := rlp.ListSize(blobtx.Sidecar.encodedSize()) | ||
| cpy.size.Store(size - scSize) | ||
| } |
Contributor
There was a problem hiding this comment.
I've been verifying this, and this part is correct, but the Size method has some issues related with the new sidecar v2. I was thinking about fixing it in this PR before merging, but will separate this out.
howjmay
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Aug 27, 2025
…reum#31990) This PR adds a block validation check for the maximum block size, as required by EIP-7934, and also applies a slightly lower size limit during block building. --------- Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Gary Rong <garyrong0905@gmail.com>
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
…reum#31990) This PR adds a block validation check for the maximum block size, as required by EIP-7934, and also applies a slightly lower size limit during block building. --------- Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Gary Rong <garyrong0905@gmail.com>
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 26, 2026
25 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 26, 2026
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 26, 2026
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 26, 2026
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 26, 2026
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Mar 27, 2026
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check against the maximum block size, as required by EIP-7934, and also applies a slightly lower
size limit during block building.