core, eth, trie, light: clean up trie interface#26388
Merged
karalabe merged 2 commits intoethereum:masterfrom Jan 3, 2023
Merged
core, eth, trie, light: clean up trie interface#26388karalabe merged 2 commits intoethereum:masterfrom
karalabe merged 2 commits intoethereum:masterfrom
Conversation
rjl493456442
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
holiman
reviewed
Dec 28, 2022
Member
Author
|
Let's hold-on this PR for a while. I am not sure the change for |
rjl493456442
force-pushed
the
cleanup-trie-interface
branch
from
b5809b5 to
45743bc
Compare
holiman
approved these changes
Dec 29, 2022
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
LGTM, only minor suggestion to name them ByHash instead of WithHash, since it refers to whether we look it up by hash.
| // We don't have the requested state snapshotted yet (or it is stale), | ||
| // but can look up the account via the trie instead. | ||
| account, err := accTrie.TryGetAccountWithPreHashedKey(pathset[0]) | ||
| account, err := accTrie.TryGetAccountWithHash(common.BytesToHash(pathset[0])) |
Contributor
There was a problem hiding this comment.
Suggested change
| account, err := accTrie.TryGetAccountWithHash(common.BytesToHash(pathset[0])) | |
| account, err := accTrie.TryGetAccountByHash(common.BytesToHash(pathset[0])) |
?
| return nil, nil | ||
| } | ||
| acc, err := accTrie.TryGetAccountWithPreHashedKey(account[:]) | ||
| acc, err := accTrie.TryGetAccountWithHash(account) |
Contributor
There was a problem hiding this comment.
Suggested change
| acc, err := accTrie.TryGetAccountWithHash(account) | |
| acc, err := accTrie.TryGetAccountByHash(account) |
?
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
* all: cleanup trie interface * eth, trie: address comments
2 tasks
2 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 20, 2025
* all: cleanup trie interface * eth, trie: address comments
19 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 17, 2025
* all: cleanup trie interface * eth, trie: address comments
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Nov 18, 2025
* all: cleanup trie interface * eth, trie: address comments Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up/improves some trie interfaces:
TryGetAccount,TryUpdateAccount,TryDeleteAccountacceptscommon.Addressas the parameters, which is more intuitive to callers