Skip to content

core, trie: clean up trie interface #26388#1125

Merged
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:cleanup-trie-interface
Nov 18, 2025
Merged

core, trie: clean up trie interface #26388#1125
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:cleanup-trie-interface

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

Proposed changes

Ref: ethereum#26388

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title core, trie: clean up trie interface #26388 [WIP] core, trie: clean up trie interface #26388 Jun 20, 2025
* all: cleanup trie interface

* eth, trie: address comments
@gzliudan gzliudan force-pushed the cleanup-trie-interface branch from efa21ac to 02ca767 Compare November 17, 2025 06:42
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@gzliudan gzliudan changed the title [WIP] core, trie: clean up trie interface #26388 core, trie: clean up trie interface #26388 Nov 17, 2025
@AnilChinchawale AnilChinchawale merged commit d47260e into XinFinOrg:dev-upgrade Nov 18, 2025
13 checks passed
@gzliudan gzliudan deleted the cleanup-trie-interface branch November 18, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants