metrics/influxdb: Support V2#23194
Conversation
jwasinger
changed the title
|
I can see that this seems to work by looking at the schemas created in Influx, and also seeing that Geth is successfully pushing data. However, I ran into issues connecting it to Grafana using the auth token. Tried adding the auth token via an http header as suggested in https://community.grafana.com/t/grafana-issue-connecting-to-influxdb-2-0-3-influxql/42757/4 . But that didn't work. I probably won't have too much free time to continue digging on that this week. But the issue doesn't seem relevant to this PR (only ensuring that it works as expected). |
jwasinger
force-pushed
the
influxdbv2
branch
2 times, most recently
from
ea6a7ff to
814912e
Compare
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
Looks pretty good to me!
…casas' changes), leave existing support for v1 to maintain backwards-compatibility. Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com> Co-authored-by: Italo A. Casas <me@italoacasas.com>
|
Rebased on master so I can test it more easily |
|
Ok, tested this with a local node against our grafana/influxv1 (obs: version 1) cluster. Seems to work fine, in the sense that it doesn't break the old stuff. |
…casas' changes), leave existing support for v1 to maintain backwards-compatibility. (ethereum#23194) This PR adds flag to enable InfluxDB v2 (--metrics.influxdbv2), flags for v2-specific features (--metrics.influxdb.token, --metrics.influxdb.bucket), also carries over addition of support for specifying organization (--metrics.influxdb.organization), but still retains backwards compatibility with InfluxDB v1.
5 participants
This PR builds on #22726:
* adds flag to enable v2 (
--metrics.influxdbv2), flags for v2-specific features (--metrics.influxdb.token,--metrics.influxdb.bucket), also carries over addition of support for specifying organization (--metrics.influxdb.organizationfrom #22726).* retains backwards compatibility with influxdb-v1.