Skip to content

metrics/influxdb: updating package to support InfluxDB v2#22726

Closed
italoacasas wants to merge 1 commit intoethereum:masterfrom
italoacasas:adding-influxdbv2
Closed

metrics/influxdb: updating package to support InfluxDB v2#22726
italoacasas wants to merge 1 commit intoethereum:masterfrom
italoacasas:adding-influxdbv2

Conversation

@italoacasas
Copy link
Copy Markdown

@italoacasas italoacasas commented Apr 23, 2021

Issue #22646

  • Currently, only InfluxDB v1.x works in the client, this PR will allow v2 to work, but v1 will not work anymore.
  • Opening the PR as a draft to get some feedback
  • I took the liberty to delete some methods that no one was using

@MariusVanDerWijden
Copy link
Copy Markdown
Member

I ran into the same issue over here: #22664
I'm not sure if we can disable v1 quite yet though @fjl

@italoacasas
Copy link
Copy Markdown
Author

italoacasas commented Apr 23, 2021

@MariusVanDerWijden If v1 cannot be dropped, maybe using https://docs.influxdata.com/influxdb/v2.0/reference/api/influxdb-1x/, we can build a compatible layer using the v2 go client

@holiman holiman self-assigned this Apr 29, 2021
@holiman
Copy link
Copy Markdown
Contributor

holiman commented Oct 31, 2021

Fixed by #23194, closing this

@holiman holiman closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants