tests/fuzzers/les: add fuzzer for les server handler#22173
Closed
zsfelfoldi wants to merge 7 commits intoethereum:masterfrom
Closed
tests/fuzzers/les: add fuzzer for les server handler#22173zsfelfoldi wants to merge 7 commits intoethereum:masterfrom
zsfelfoldi wants to merge 7 commits intoethereum:masterfrom
Conversation
zsfelfoldi
requested review from
gballet,
holiman,
karalabe,
ligi and
rjl493456442
as code owners
|
|
||
| // New creates an instance of the light client. | ||
| func New(stack *node.Node, config *eth.Config) (*LightEthereum, error) { | ||
| func New(stack *node.Node, config *eth.Config, mkEngineFn consensusCreatorFn) (*LightEthereum, error) { |
Member
There was a problem hiding this comment.
It's unnecessary I think? We can move this function into the consensus package so that it can be shared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the LES server handler in order to make fuzzer testing possible and implements the fuzzer.
Note: it is based on top of #22154 which is WIP and removes package dependencies in order to make fuzzing of package les possible. Alternatively #22161 could solve the same problem. Finishing and merging both of these two PRs might make sense but either one alone should make LES fuzzing possible.