les: do not directly import package eth from les#22154
Closed
zsfelfoldi wants to merge 5 commits into
Closed
Conversation
holiman
reviewed
Jan 10, 2021
|
|
||
| // New creates an instance of the light client. | ||
| func New(stack *node.Node, config *eth.Config) (*LightEthereum, error) { | ||
| func New(stack *node.Node, config *eth.Config, cc consensusCreatorFn) (*LightEthereum, error) { |
Contributor
There was a problem hiding this comment.
Let's use something a bit more friendly, perhaps
Suggested change
| func New(stack *node.Node, config *eth.Config, cc consensusCreatorFn) (*LightEthereum, error) { | |
| func New(stack *node.Node, config *eth.Config, mkEngineFn consensusCreatorFn) (*LightEthereum, error) { |
Contributor
|
The config should probably live in a 'data package' that's shared between les and eth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring in order to remove all imports of package eth from package les (except for api_test which is an end-to-end test). Dependence on the eth package was ugly anyway but the current reason is that eth package imports the tracer which imports duktape which cannot be compiled with CGO and therefore go-fuzz could not fuzz anything in package les.