log: delete RotatingFileHandler#20586
Merged
karalabe merged 2 commits intoethereum:masterfrom Jan 21, 2020
Merged
Conversation
We added this for the dashboard, which is gone now. The handler never really worked well and had data race and file handling issues.
This was referenced Jan 21, 2020
fjl
force-pushed
the
log-delete-rotating-file
branch
from
f5170e0 to
9126062
Compare
karalabe
approved these changes
Jan 21, 2020
kjx98
pushed a commit
to kjx98/go-ethereum
that referenced
this pull request
Jan 23, 2020
* log: delete RotatingFileHandler We added this for the dashboard, which is gone now. The handler never really worked well and had data race and file handling issues. * internal/debug: remove unused RotatingFileHandler setup code
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
* log: delete RotatingFileHandler We added this for the dashboard, which is gone now. The handler never really worked well and had data race and file handling issues. * internal/debug: remove unused RotatingFileHandler setup code
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 15, 2024
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added this for the dashboard, which is gone now. The
handler never really worked well and had data race and file
handling issues.