Skip to content

log: close log file before calling truncate on windows#20556

Closed
kukugi wants to merge 1 commit intoethereum:masterfrom
kukugi:log_truncate
Closed

log: close log file before calling truncate on windows#20556
kukugi wants to merge 1 commit intoethereum:masterfrom
kukugi:log_truncate

Conversation

@kukugi
Copy link
Copy Markdown

@kukugi kukugi commented Jan 14, 2020

If you truncate an open file in Windows, access is denied.
how about close the file before truncation?

   If you truncate an open file in Windows, access is denied.
   how about close the file before truncation?
@fjl
Copy link
Copy Markdown
Contributor

fjl commented Jan 21, 2020

We have decided to remove RotatingFileHandler instead of fixing it because the handler has other issues and is not used by go-ethereum. It is removed in PR #20586.

@fjl fjl closed this Jan 21, 2020
@fjl fjl removed the status:triage label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants