les: move protocol definition to sub-package#20516
Closed
rjl493456442 wants to merge 4 commits intoethereum:masterfrom
Closed
les: move protocol definition to sub-package#20516rjl493456442 wants to merge 4 commits intoethereum:masterfrom
rjl493456442 wants to merge 4 commits intoethereum:masterfrom
Conversation
It's first step of refactor LES package. LES package basically can be divided into LES client and LES server. However both sides will use checkpoint package for status retrieval and verification. So this PR moves checkpoint oracle into a separate package
execqueue is a util for executing queued functions in a serial order which is used by both les server and les client. Move it to common package.
weighted_random_selector is a helpful tool for randomly select items maintained in a set but based on the item weight. It's used anywhere is LES package, mainly by les client but will be used in les server with very high chance. So move it into a common package as the second step for les separation.
Contributor
|
Waiting for #20517 to be merged |
Contributor
|
I think we can close this now. It's one year old, and a lot of LES has already moved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the third step of LES refactoring based on the #20508 and #20509