les: move the checkpoint oracle into its own package#20508
Merged
karalabe merged 2 commits intoethereum:masterfrom Jan 7, 2020
Merged
les: move the checkpoint oracle into its own package#20508karalabe merged 2 commits intoethereum:masterfrom
karalabe merged 2 commits intoethereum:masterfrom
Conversation
It's first step of refactor LES package. LES package basically can be divided into LES client and LES server. However both sides will use checkpoint package for status retrieval and verification. So this PR moves checkpoint oracle into a separate package
karalabe
reviewed
Jan 6, 2020
|
|
||
| // newCheckpointOracle returns a checkpoint registrar handler. | ||
| func newCheckpointOracle(config *params.CheckpointOracleConfig, getLocal func(uint64) params.TrustedCheckpoint) *checkpointOracle { | ||
| // NewCheckpointOracle returns a checkpoint oracle handler. |
Member
There was a problem hiding this comment.
Please rename this to New to avoid stuttering at call sites: checkpointoracle.NewCheckpointOracle vs checkpointoracle.New
Member
Author
|
@karalabe Fixed, thanks for review! |
This was referenced Jan 7, 2020
Closed
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
* les: move the checkpoint oracle into its own package It's first step of refactor LES package. LES package basically can be divided into LES client and LES server. However both sides will use checkpoint package for status retrieval and verification. So this PR moves checkpoint oracle into a separate package * les: address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's first step of refactor LES package. LES package
basically can be divided into LES client and LES server.
However both sides will use checkpoint package for
status retrieval and verification. So this PR moves
checkpoint oracle into a separate package