internal/ethapi: don't query wallets at every execution of gas estimation#20261
Merged
karalabe merged 1 commit intoethereum:masterfrom Nov 20, 2019
Merged
internal/ethapi: don't query wallets at every execution of gas estimation#20261karalabe merged 1 commit intoethereum:masterfrom
karalabe merged 1 commit intoethereum:masterfrom
Conversation
Member
|
Could you do the same pls in account/abi/bind/backends/simulated.go? |
Member
|
Also pls fix the commit msg typos |
karalabe
reviewed
Nov 12, 2019
karalabe
reviewed
Nov 12, 2019
fjl
changed the title
Contributor
|
Why are we auto-setting the sender address at all? |
Member
|
Legacy API behavior, use account[0] if unset. |
Member
|
I'd be happy to start rejecting this behavior, but that's a breaking enough change IMHO to warrant a major Geth version bump (as in 1.10) |
Contributor
Author
Afaict, that one doesn't use the accounts. It takes an |
holiman
force-pushed
the
less_querying
branch
from
2a42927 to
51c3290
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user ( @sarvesh-ost ) reported that doing
estimateGaswith clef as a backend caused it to prompt for approval 26 times.This PR changes the gas estimator so it resolves the address to use only once, not once for each execution.
@sarvesh-ost , could you please check if this solves the issue?