Skip to content

Fix & Update EstimateGas API#462

Open
c98tristan wants to merge 20 commits intoBuildOnViction:pre-releasefrom
c98tristan:feat/update-estimate-gas
Open

Fix & Update EstimateGas API#462
c98tristan wants to merge 20 commits intoBuildOnViction:pre-releasefrom
c98tristan:feat/update-estimate-gas

Conversation

@c98tristan
Copy link
Copy Markdown
Contributor

@c98tristan c98tristan commented Oct 10, 2024 •
edited
Loading

  1. Fix too many arguments, want at most 1 when call eth_estimateGas
  2. Fix default gasPrice depend on balanceTokenFee
  3. Add executionResult to emphasizes the difference between Consensus error and EVM internal error.
  4. Fix race condition by copy state from stateDB each execution.
  5. Optimize time execution estimate gas.
  6. Get balanceTokenFee from stateDB instead of default value
  7. Remove gasLimit and gasPrice when using contract call
  8. Remove logic set gasPrice when balanceTokenFee exist.
  9. Unit testing

Reference:

@c98tristan
fix(crypto/bn256/cloudflare): pull in upstream fix for Go 1.21 R18
603983b
@c98tristan
refactor: PR #18445 - CallArgs and estimateGas API
ff40ce2
@c98tristan
refactor: PR #20261 #20702 - Use from address only once, Set sender t…
7b74145 
…o 0x00
@c98tristan
refactor: comment balanceTokenFee related code & add unit test
1313614
@c98tristan
fix: PR #20783 unusual balance return, set gasPrice to zero
36ff14e
@c98tristan
refactor: PR #20830, #21083 add executionResult, return revert reason
6c30566
@c98tristan
feat: PR #21043 recap highest gas limit with account's balance
876f2d5
@c98tristan
feat: PR #21346 add more condition check prevent unnecessary failures…
09f740f 
… during gas estimation
@c98tristan
refactor: remove gas price and gas limit in validator call message
419e7fc
@c98tristan
feat: PR #21545, #24363: EstimateGas function add block number parame…
7f89afb 
…ter and use LatestBlockNumber by default
@c98tristan
refactor:
33c58ad 
PR #27505: Each binary search call retrieve new copy of the state
Remove old EstimateGas function
Fix unit test
@c98tristan
refactor:
e3d8644 
PR #27710: Optimize and clean EstimateGas function
@c98tristan
feat: add balanceTokenFee logic, remove comment code
7765eed
@c98tristan
fix: refundGas if balanceTokenFee == nil
1bc0cc5
@c98tristan
chore: integration test free gas transaction
2f1435d
@c98tristan
fix: PR #21601 fix null pointer exception, add estimate gas to js
d2c4b91
@c98tristan c98tristan marked this pull request as ready for review October 23, 2024 10:38
@imterryyy
Copy link
Copy Markdown
Collaborator

imterryyy commented Oct 24, 2024

Does this change require protocol update ?

@imterryyy
Copy link
Copy Markdown
Collaborator

imterryyy commented Nov 28, 2024

Fix: #483

@c98tristan c98tristan changed the base branch from master to pre-release April 23, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Christymulligan7 Christymulligan7 Christymulligan7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c98tristan @imterryyy @Christymulligan7