Skip to content

internal/debug: support color terminal for cygwin/msys2#17740

Merged
fjl merged 3 commits intoethereum:masterfrom
hackmod:cygwin-fixes
Sep 29, 2018
Merged

internal/debug: support color terminal for cygwin/msys2#17740
fjl merged 3 commits intoethereum:masterfrom
hackmod:cygwin-fixes

Conversation

@hackmod
Copy link
Copy Markdown
Contributor

@hackmod hackmod commented Sep 22, 2018

fixed color terminal support for cygwin/msys2

  • update go-colorable, go-isatty, go-runewidth packages
  • use go-isatty instead of log/term and remove log/term package

fixed default data path issue under cygwin/msys2

  • use APPDATA env variable for windows

Comment thread node/defaults.go Outdated
@fjl fjl changed the title support color terminal for cygwin/msys2 internal/debug: support color terminal for cygwin/msys2 Sep 28, 2018
@fjl
Copy link
Copy Markdown
Contributor

fjl commented Sep 28, 2018

Please remove the change in package node for now. We can make it in a separate PR.

@fjl fjl merged commit 44eb695 into ethereum:master Sep 29, 2018
@mksully22
Copy link
Copy Markdown

can you provide some insight on why building for ppc64 and ppc64le was disabled for vendor/github.com/mattn/go-isatty/isatty_linux.go module?

@hackmod
Copy link
Copy Markdown
Contributor Author

hackmod commented Jan 1, 2019

@mksully22 oops! some files are missing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants