community/geth: fix ppc64le build break by re-enabling isatty termina…#5954
Closed
mksully22 wants to merge 1 commit intoalpinelinux:masterfrom
Closed
community/geth: fix ppc64le build break by re-enabling isatty termina…#5954mksully22 wants to merge 1 commit intoalpinelinux:masterfrom
mksully22 wants to merge 1 commit intoalpinelinux:masterfrom
Conversation
|
oops! last change missing some files |
|
Merged in 75b3245 by @ncopa. Thanks for your contribution! (This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l functions
ethereum/go-ethereum#17740 disabled building isatty_linux.go for ppc64,ppc64le which makes these functions unavailable when building flags.go and color.go modules for geth. This patch allows the isatty_linux.go module to be built for ppc64le so geth build requirements are fixed.
A post was added to ethereum/go-ethereum#17740 to try and understand better why this was disabled in the first place for ppc64le.