Skip to content

fix(spec-specs): Move account closure log emission before priority fee charges#2059

Merged
fselmo merged 6 commits into
ethereum:eips/amsterdam/eip-7708from
Carsons-Eels:fix-7708-closure-log-emit
Jan 23, 2026
Merged

fix(spec-specs): Move account closure log emission before priority fee charges#2059
fselmo merged 6 commits into
ethereum:eips/amsterdam/eip-7708from
Carsons-Eels:fix-7708-closure-log-emit

refactor(spec-specs): move post-mining coinbase balance calculation

8ea2cef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2026 in 0s

86.15% (+0.01%) compared to bf16746

View this Pull Request on Codecov

86.15% (+0.01%) compared to bf16746

Details

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.15%. Comparing base (bf16746) to head (8ea2cef).
⚠️ Report is 18 commits behind head on eips/amsterdam/eip-7708.

Files with missing lines Patch % Lines
src/ethereum/forks/amsterdam/fork.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7708    #2059      +/-   ##
===========================================================
+ Coverage                    86.14%   86.15%   +0.01%     
===========================================================
  Files                          599      599              
  Lines                        39491    39507      +16     
  Branches                      3782     3785       +3     
===========================================================
+ Hits                         34021    34039      +18     
+ Misses                        4848     4847       -1     
+ Partials                       622      621       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.