fix(spec-specs): Move account closure log emission before priority fee charges by Carsons-Eels · Pull Request #2059 · ethereum/execution-specs

Carsons-Eels · 2026-01-22T05:51:25Z

🗒️ Description

Current branch is out of spec. I noticed after I had already merged to our staging branch that the account closure logs are supposed to be emitted "before charging the EIP-1559 priority fee" according to the language of the EIP. Currently this happens after.

🔗 Related Issues or PRs

N/A.

✅ Checklist

All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
uvx tox -e static
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
All: Considered updating the online docs in the ./docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

“Rats” by Carsten ten Brink, CC BY-NC-ND 2.0

…e charges

codecov · 2026-01-22T07:23:55Z

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.15%. Comparing base (bf16746) to head (8ea2cef).
⚠️ Report is 19 commits behind head on eips/amsterdam/eip-7708.

Files with missing lines	Patch %	Lines
src/ethereum/forks/amsterdam/fork.py	71.42%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7708    #2059      +/-   ##
===========================================================
+ Coverage                    86.14%   86.15%   +0.01%     
===========================================================
  Files                          599      599              
  Lines                        39491    39507      +16     
  Branches                      3782     3785       +3     
===========================================================
+ Hits                         34021    34039      +18     
+ Misses                        4848     4847       -1     
+ Partials                       622      621       -1

Flag	Coverage Δ
unittests	`86.15% <75.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

spencer-tb

Changes make sense to me!

spencer-tb · 2026-01-22T12:09:29Z

The CI fails are from this change as far as I can tell! So fine in my opinion. We'd need to regenerate a new release, update the BAL release in CI, and re-run to get these to pass so chicken & egg problem.

spencer-tb · 2026-01-22T12:52:51Z

I tried looking into adding a test to verify finalization logs are emitted before the priority fee payment, but I don't think this is testable:

Finalization logs only apply to contracts in accounts_to_delete
Per EIP-6780, only contracts created in the same tx are added to accounts_to_delete
For priority fee timing to matter, the selfdestructed contract would need to be the coinbase
But the coinbase is set in the block header before the tx runs, so it can't be a contract created in
the same tx

…e charges (#2059) * fix(spec-specs): Move account closure log emission before priority fee charges * fix(spec-specs): formatting and spelling tweaks * fix(spec-specs): remove duplicate WriteInStaticContext check * refactor(spec-specs): align memory expansion with other opcodes * fix(testing/test): Fix unit test expectation * refactor(spec-specs): move post-mining coinbase balance calculation --------- Co-authored-by: Mario Vega <marioevz@gmail.com>

…_excess_blob_gas_fork_transition.py` (ethereum#2059) * fix(test): Change excess_blob_gas to header_verify to catch the issue * fix(tests): Fix tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py to guarantee base fee in blocks

…e charges (#2059) * fix(spec-specs): Move account closure log emission before priority fee charges * fix(spec-specs): formatting and spelling tweaks * fix(spec-specs): remove duplicate WriteInStaticContext check * refactor(spec-specs): align memory expansion with other opcodes * fix(testing/test): Fix unit test expectation * refactor(spec-specs): move post-mining coinbase balance calculation --------- Co-authored-by: Mario Vega <marioevz@gmail.com>

…e charges (ethereum#2059) * fix(spec-specs): Move account closure log emission before priority fee charges * fix(spec-specs): formatting and spelling tweaks * fix(spec-specs): remove duplicate WriteInStaticContext check * refactor(spec-specs): align memory expansion with other opcodes * fix(testing/test): Fix unit test expectation * refactor(spec-specs): move post-mining coinbase balance calculation --------- Co-authored-by: Mario Vega <marioevz@gmail.com>