Skip to content

fix(tests-execute): relax pydantic checks on GetPayloadResponse#2039

Merged
fselmo merged 1 commit intoethereum:forks/amsterdamfrom
danceratopz:fix-extra-fields-execute
Jan 19, 2026
Merged

fix(tests-execute): relax pydantic checks on GetPayloadResponse#2039
fselmo merged 1 commit intoethereum:forks/amsterdamfrom
danceratopz:fix-extra-fields-execute

Conversation

@danceratopz
Copy link
Member

@danceratopz danceratopz commented Jan 19, 2026

🗒️ Description

Following stricter checks in #2000, this fixes the pydantic error below when running:

uv run execute hive --fork=Prague -v -m blob_transaction_test

Note, more fixes will be required for blob_transaction_test working with execute (WIP), but they have different root causes.

Error

__________________________________________ ERROR at setup of test_get_blobs[fork_Prague-single_blob_transaction-blob_transaction_test] ___________________________________________
packages/testing/src/execution_testing/cli/pytest_commands/plugins/execute/pre_alloc.py:212: in execute_required_contracts
    deploy_deterministic_factory_contract(
packages/testing/src/execution_testing/cli/pytest_commands/plugins/execute/contracts.py:82: in deploy_deterministic_factory_contract
    eth_rpc.send_wait_transaction(fund_tx)
packages/testing/src/execution_testing/rpc/rpc.py:720: in send_wait_transaction
    self.send_transaction(transaction)
packages/testing/src/execution_testing/cli/pytest_commands/plugins/execute/rpc/chain_builder_eth_rpc.py:372: in send_transaction
    self.generate_block()
packages/testing/src/execution_testing/cli/pytest_commands/plugins/execute/rpc/chain_builder_eth_rpc.py:326: in generate_block
    new_payload = self.engine_rpc.get_payload(
packages/testing/src/execution_testing/rpc/rpc.py:862: in get_payload
    return GetPayloadResponse.model_validate(
E   pydantic_core._pydantic_core.ValidationError: 2 validation errors for GetPayloadResponse
E   blockValue
E     Extra inputs are not permitted [type=extra_forbidden, input_value='0x7558cd118', input_type=str]
E       For further information visit https://errors.pydantic.dev/2.12/v/extra_forbidden
E   shouldOverrideBuilder
E     Extra inputs are not permitted [type=extra_forbidden, input_value=False, input_type=bool]
E       For further information visit https://errors.pydantic.dev/2.12/v/extra_forbidden

The above exception was the direct cause of the following exception:
packages/testing/src/execution_testing/cli/pytest_commands/plugins/execute/pre_alloc.py:218: in execute_required_contracts
    raise RuntimeError(
E   RuntimeError: Error deploying deterministic deployment contract:
E   2 validation errors for GetPayloadResponse
E   blockValue
E     Extra inputs are not permitted [type=extra_forbidden, input_value='0x7558cd118', input_type=str]
E       For further information visit https://errors.pydantic.dev/2.12/v/extra_forbidden
E   shouldOverrideBuilder
E     Extra inputs are not permitted [type=extra_forbidden, input_value=False, input_type=bool]
E       For further information visit https://errors.pydantic.dev/2.12/v/extra_forbidden
E   Try deploying the contract manually using a different RPC endpoint with the following command:
E   uv run execute deploy-required-contracts

🔗 Related Issues or PRs

Stricter pydantic checks were enabled in:

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.

  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

image

@danceratopz danceratopz added A-test-execute Area: execution_testing.cli.pytest_commands.plugins.execute C-bug Category: this is a bug, deviation, or other problem labels Jan 19, 2026
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (eeb65f7) to head (d4c9ae6).
⚠️ Report is 3 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2039   +/-   ##
================================================
  Coverage            86.07%   86.07%           
================================================
  Files                  599      599           
  Lines                39527    39527           
  Branches              3780     3780           
================================================
  Hits                 34021    34021           
  Misses                4872     4872           
  Partials               634      634           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@fselmo fselmo merged commit e0c64f0 into ethereum:forks/amsterdam Jan 19, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-execute Area: execution_testing.cli.pytest_commands.plugins.execute C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants