fix(test-types): Loosen pydantic strictness on internal pydantic models#2000
Merged
fselmo merged 3 commits intoethereum:forks/amsterdamfrom Jan 9, 2026
Merged
Conversation
2bb50ae to
14becb5
Compare
8 tasks
fselmo
commented
Jan 9, 2026
14becb5 to
d1b880e
Compare
d1b880e to
35cf414
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2000 +/- ##
================================================
Coverage 86.33% 86.33%
================================================
Files 538 538
Lines 34557 34557
Branches 3222 3222
================================================
Hits 29835 29835
Misses 4148 4148
Partials 574 574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 13, 2026
jsign
pushed a commit
to jsign/execution-specs
that referenced
this pull request
Jan 20, 2026
…thereum#2000) This adds test cases for BLS precompiles where one of the point (G1/G2) coordinates is "slightly" above the value of the field prime P. The "slightly above" means that a valid point is modified by adding P to one of its field elements. Such test case has a chance of detecting an invalid implementation where the field element is loaded as 384-bit integer and converted to the Montgomery form. The Montgomery form round-trip has the effect of computing a value mod P, i.e. `(x + P) % P` gives `x` and the invalid point becomes valid. In the similar way test cases may be extended to other BLS precompiles. However, I assume BLS precompiles implementations share the input validation code.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Alternate solution to #1997.
Fix #1998 and #1999 by loosening restrictions on internal models. The goal of keeping some models strict and explicitly turning strictness off is so test writers have their code raise errors if they provide incorrect fields, not so we can be sticklers on internal models. This will only cause headaches I believe.
🔗 Related Issues or PRs
closes #1998
closes #1999
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture