fix(test-types): format Transaction values as readable hex-strings instead of raw bytes (#1803)

[felix314159]

🗒️ Description

a = Transaction()
print(f"{a}")

Before this PR the resulting log is unreadable, you don't even see who is sending to who. With this PR you get readable addresses 0x...

🔗 Related Issues or PRs

N/A.

✅ Checklist

• All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  uvx tox -e static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered adding an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
• Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

[fselmo]

I support better readability 👌🏼. Just a minor suggestion for generalizing it to other fields with hex support. Can do another pass after this is rebased.

[felix314159]

TIL:
git commit -m "abc `def` ghi" shows up as "abc ghi"
but
git commit -m 'abc `def` ghi' shows up as "abc def ghi`

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.33%. Comparing base (3a3bb33) to head (92b855c).
⚠️ Report is 6 commits behind head on forks/amsterdam.

Additional details and impacted files

@@               Coverage Diff                @@
##           forks/amsterdam    #1803   +/-   ##
================================================
  Coverage            86.33%   86.33%           
================================================
  Files                  538      538           
  Lines                34557    34557           
  Branches              3222     3222           
================================================
  Hits                 29835    29835           
  Misses                4148     4148           
  Partials               574      574           

Flag	Coverage Δ
unittests	86.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[danceratopz]

@felix314159 just rebased on main to get the potential fix from:

• fix(test-tests): prevent race condition in gentest tests w/xdist #2009

[danceratopz]

capture_gentest.py

Thanks for adding this @felix314159! The CI fails were not due to a race condition while executing the gentest tests via CliRunner. gentest formats the generated code with ruff, which was failing because it generated invalid Python code until the fix from @fselmo was applied (f'"{value.hex()}"' instead of value.hex(), to ensure 0x0, not 0x was returned).

After seeing this fail (which is now fixed), I thought wed better check what else has changed with the output of gentest and these changes do greatly improve situation for Address objects (which was a long time coming, so thanks!), but actually regresses the situation for numeric values, such as gas_price. The following summarizes the situation.

The _format_field_value change improves readability for addresses and bytes data, but reduces readability for numeric fields.

Examples from gentest output

Addresses/Data (improved):

# Before: raw bytes (hard to read)
to=b'\xc6\xd9g\x86G\x7f\x82I\x1b\xfe\xad\x8f\x00\xb8)F\x88\xf7z\xbc'
data=b''

# After: hex strings (readable)
to="0xc6d96786477f82491bfead8f00b8294688f77abc"
data="0x"

Numeric fields (regressed):

# Before: decimal (clear)
gas_price=10000000000  # obviously 10 gwei
value=668250000000000000
nonce=2

# After: hex strings (opaque)
gas_price="0x2540be400"  # what's this in gwei?
value="0x94619d59f27a000"
nonce="0x2"

Suggestion

Consider making _format_field_value more nuanced:

• Addresses/Bytes → use hex string (current behavior, good)
• Integers/HexNumber → keep as decimal repr (better for readability)

This could be done by checking the type more specifically rather than just hasattr(value, "hex").

I attached the script that Claude wrote to help compare the output.

[felix314159]

Sorry I thought I had the SLOTNUM PR open when changing the target branch here :D

[danceratopz]

Thanks @felix314159, here's few comments on the last change.

[danceratopz]

Thanks for this improvement, @felix314159! LGTM!

[fselmo]

You've got my approval as well, thanks for this! Let's just make sure to squash + merge 😅.