feat(benchmarks): fix bytecode attack for EXT-like opcodes to work in Osaka #1971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR builds on the work in #1850 to fix the remaining
EXT*mechanisms for accessing unchunkified bytecode.After thinking it over, it makes sense to unify the benchmarks as initially done. The benchmark code is the same. I also think that the primary goal of the benchmark is not "generic usage" of these opcodes, but specifically on the unchunkified bytecode scenario, so I changed the benchmark name accordingly.
If this isn't convincing, I can keep them split and extract the whole internal logic to some other place and use it literally for both EXT* and CALL*. I just think that's quite awkard and why I ended up unifying and deciding on a more meaningful name on the scenario being benchmarked.
🔗 Related Issues or PRs
#1695
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.