-
Notifications
You must be signed in to change notification settings - Fork 419
feat(ci): add hive consume test workflow #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add hive consume test workflow #1692
Conversation
27793d7 to
7d6b9fd
Compare
|
Passing them here: https://github.com/ethereum/execution-specs/actions/runs/18876034305/job/53865955924?pr=1692 I added the filtering back now so this is ready for review! |
danceratopz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need a rebase - I will do this and address some issues directly :)
3117075 to
d8a9fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spencer-tb this is awesome, we've been missing this for a while! 😅
I rebased so I could fix-up the paths, added a couple more paths to trigger the workflow and updated to hte astral-sh/update-uv action.
One other suggestion below.
Co-authored-by: danceratopz <[email protected]>
0c663b2 to
f4a149b
Compare
Description
Adds a CI workflow to validate hive integration with consume commands. Previously, we lacked CI for consume, which has led to breaking changes going undetected until they impacted downstream EL clients.
This workflow provides early detection of consume-related regressions, preventing disruption to client teams who depend on our test fixtures.
What's Tested
The workflow runs four parallel test jobs:
ethereum/eels/consume-engineethereum/eels/consume-rlpethereum/eels/consume-syncethereum/eels/consume-engineDev mode validationAll tests use
go-ethereumas the reference client and filter to a subset of Osaka fork tests to keep CI runtime reasonable while still providing meaningful coverage. We pull the latestgo-ethereumimage fromethpandaops.We run a single test just to check for no fails. It assumes
go-ethereumwill pass this test always. It takes no longer that 5 minutes to run the workflow.We may consider expanding the filter for when we run this workflow, to include any changes to
packages/testing.