Skip to content

Detect state tests via "parentHash" field #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petertdavies wants to merge 1 commit into from
Closed

Detect state tests via "parentHash" field #1006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ethereum_spec_tools/evm_tools/t8n/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ def __init__(self, t8n: "T8N", stdin: Optional[Dict] = None):
with open(t8n.options.input_env, "r") as f:
data = json.load(f)

if "parentHash" not in data:
Copy link
Contributor

@SamWilsn SamWilsn Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather avoid cases like this. They tend to accumulate over time and make the command-line interface less straightforward.

Can we fix EEST to add the --state-test flag?

# Sometimes we are given a state test without the --state-test
# flag being set. This hack detects those cases and treats them
# as state tests.
t8n.options.state_test = True

self.coinbase = t8n.fork.hex_to_address(data["currentCoinbase"])
self.block_gas_limit = parse_hex_or_int(data["currentGasLimit"], Uint)
self.block_number = parse_hex_or_int(data["currentNumber"], Uint)
Expand Down