Detect state tests via "parentHash" field#1006
Closed
petertdavies wants to merge 1 commit intoethereum:forks/praguefrom
Closed
Detect state tests via "parentHash" field#1006petertdavies wants to merge 1 commit intoethereum:forks/praguefrom
petertdavies wants to merge 1 commit intoethereum:forks/praguefrom
Conversation
SamWilsn
reviewed
Sep 10, 2024
| with open(t8n.options.input_env, "r") as f: | ||
| data = json.load(f) | ||
|
|
||
| if "parentHash" not in data: |
Contributor
There was a problem hiding this comment.
I would rather avoid cases like this. They tend to accumulate over time and make the command-line interface less straightforward.
Can we fix EEST to add the --state-test flag?
This was referenced Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
EEST is feeding t8n state tests with telling us they are state tests. There is no standardised way to detect them.
How was it fixed?
Add a hack that assumes any test missing the
"parentHash"field is a state test.Cute Animal Picture