feat(tests): add reentrancy suicide revert test

[winsvega]

🗒️ Description

Test requested by chfast about suicide reentrancy and revert.

🔗 Related Issues

Resolves this issue.

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[marioevz]

Looks great to me :) Just a few comments, which might need a rebase.

It might be worth it to run tox to highlight any other issues related to linting if any (Just run tox in the execution-spec-tests folder with venv enabled).

[spencer-tb]

LGTM!

I'm nit-picking but it would be good to follow these 2 additional items that we started a few months ago. They don't need to be perfect but should help us in the future for finding issues or PRs in the future.

1. Using a similar naming conventions in the PRs (and issues as well), to make it super easy to find again in the future if something related pops up. A good example for this PR is feat(tests): update kzg point evaulation test vectors to official setup #336. So renaming it to something like:
   feat(tests): add double suicide revert test

2. Using the checklist in the PR draft: https://github.com/ethereum/execution-spec-tests/blob/main/.github/PULL_REQUEST_TEMPLATE.md.

• Tagging the related issues.
• Adding the appropriate labels, personally I'd add type:feat and scope:tests.
• Adding a line to the changelog.

[winsvega]

Can this also be scripted in github CI checks?

[spencer-tb]

Great idea, for the labels most likely and similarly with the Changelog!

Maybe after a PR is created, depending on the labels assigned by the CI, the relavent PR name is given.

Can discuss on this weeks call :)

[winsvega]

git commit also should have feat(tests): add double suicide revert test message?

[winsvega]

Also CI should try to fill the test and see if it actually fills without errors

[spencer-tb]

git commit also should have feat(tests): add double suicide revert test message?

I'd say the ideal scenario is to have a single squashed commit message with the above yeah - purely for improved commit history on main :)

Also CI should try to fill the test and see if it actually fills without errors

Tox should already be doing this, in the order specified within the tox.ini file

• First for forks <=Shanghai -> here
• Then for development forks =Cancun -> here