Skip to content

Conversation

@danceratopz
Copy link
Member

@danceratopz danceratopz commented Oct 17, 2023

🗒️ Description

Updates the point evaluation test vectors in ./tests/cancun/eip4844_blobs/point_evaluation_vectors/go_kzg_4844_verify_kzg_proof.json.

For details of the test cases taken see the README.

As of 2023-10-17: Unsure how final we are our, PR is still open: ethereum/consensus-specs#3521

EVM t8n tool version: TBA

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature labels Oct 17, 2023
@danceratopz danceratopz marked this pull request as draft October 17, 2023 10:51
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@marioevz marioevz marked this pull request as ready for review October 19, 2023 18:58
@marioevz marioevz force-pushed the feat/tests/update-kzg-point-evaluation-test-vectors-to-official-setup branch from 3cd2f86 to 2de35d0 Compare October 19, 2023 19:07
@marioevz marioevz merged commit 4871503 into ethereum:main Oct 19, 2023
@danceratopz danceratopz deleted the feat/tests/update-kzg-point-evaluation-test-vectors-to-official-setup branch October 20, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants