C++: Add execute() overloading without evmc_context parameter #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
cpp_execute_without_context
branch
from
36dbcfd
to
1b7104e
Compare
|
I'm not fully sure we can do this: #283 (comment) |
axic
reviewed
Jun 2, 2019
|
@chfast what about this? |
|
I'm little uncertain about this because the precompiles use case has not kicked off yet. |
chfast
force-pushed
the
cpp_execute_without_context
branch
3 times, most recently
from
58a36c2
to
6ebaf52
Compare
|
LOL, this is big now. |
gumb0
reviewed
Nov 5, 2019
gumb0
reviewed
Nov 5, 2019
|
clang38 and lint builds failed |
chfast
force-pushed
the
cpp_execute_without_context
branch
from
b770339
to
cee05a7
Compare
|
Rebased. |
chfast
force-pushed
the
cpp_execute_without_context
branch
from
d72a5c2
to
aa34711
Compare
axic
approved these changes
Nov 5, 2019
gumb0
approved these changes
Nov 5, 2019
chfast
force-pushed
the
cpp_execute_without_context
branch
from
aa34711
to
b1ef999
Compare
chfast
force-pushed
the
cpp_execute_without_context
branch
from
b1ef999
to
b8dde4a
Compare
|
All should be fixed. Will merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #299. Part of #259.