tests: add test case for precompile implementation #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
May 14, 2019
| @@ -44,7 +44,7 @@ static evmc_result execute_empty(const evmc_message* msg) | |||
| static evmc_result not_implemented() | |||
| { | |||
| auto result = evmc_result{}; | |||
| result.status_code = EVMC_INTERNAL_ERROR; | |||
| result.status_code = EVMC_REJECTED; | |||
There was a problem hiding this comment.
We have this special case for non-supported code/message. I think it fits better.
Also we have the specialised EVMC_PRECOMPILE_FAILURE which we don't use in this example.
axic
force-pushed
the
test-precompiles
branch
2 times, most recently
from
9482672
to
1dc7098
Compare
axic
commented
May 15, 2019
axic
commented
May 15, 2019
test/vmtester/tests.cpp
Outdated
| EVMC_CREATE, 0, 0, 65536, destination, evmc_address{}, NULL, 0, evmc_uint256be{}, | ||
| evmc_bytes32{}}; | ||
|
|
||
| evmc_result result = vm->execute(vm, context, EVMC_MAX_REVISION, &msg, nullptr, 0); |
There was a problem hiding this comment.
Should even set context to nullptr according to the EIP.
There was a problem hiding this comment.
Actually it may be needed to check callvalue and sender.
There was a problem hiding this comment.
Both are available in the message.
|
@chfast can I get a review? |
chfast
reviewed
May 21, 2019
test/vmtester/tests.cpp
Outdated
| EVMC_CREATE, 0, 0, 65536, destination, evmc_address{}, NULL, 0, evmc_uint256be{}, | ||
| evmc_bytes32{}}; | ||
|
|
||
| evmc_result result = vm->execute(vm, context, EVMC_MAX_REVISION, &msg, nullptr, 0); |
axic
force-pushed
the
test-precompiles
branch
2 times, most recently
from
0aad350
to
fd1eb3f
Compare
|
I think now this should be in line with ethereum/EIPs#2003 |
chfast
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #259.