Update storage methods #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Sep 6, 2018
| @@ -106,7 +106,11 @@ func getStorage(pResult *C.struct_evmc_uint256be, pCtx unsafe.Pointer, pAddr *C. | |||
| func setStorage(pCtx unsafe.Pointer, pAddr *C.struct_evmc_address, pKey *C.struct_evmc_uint256be, pVal *C.struct_evmc_uint256be) C.enum_evmc_storage_status { | |||
| idx := int((*C.struct_extended_context)(pCtx).index) | |||
| ctx := getHostContext(idx) | |||
| return C.enum_evmc_storage_status(ctx.SetStorage(goAddress(*pAddr), goHash(*pKey), goHash(*pVal))) | |||
| status, err := ctx.SetStorage(goAddress(*pAddr), goHash(*pKey), goHash(*pVal)) | |||
There was a problem hiding this comment.
Don't care too much, but why not just require SetStorage return this code too?
There was a problem hiding this comment.
I guess this is more aligned with Go convention to return errors as error type and additional output.
axic
reviewed
Sep 6, 2018
| auto it = host->accounts.find(*address); | ||
| if (it != host->accounts.end()) | ||
| { | ||
| *result = it->second.storage[*key]; |
There was a problem hiding this comment.
What happens when the key is not found?
There was a problem hiding this comment.
It magically inserts the null hash to the map at this position and returns it.
There was a problem hiding this comment.
Ah right because it is the index and not .at. Damn C++, damn.
There was a problem hiding this comment.
I think this is mostly to allow insertion in form of m["hello"] = "world".
axic
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146