-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return bool from get_storage and set_storage #146
Comments
I think this still makes sense because the function still has an |
Well it would return a null hash in this case (as it does currently). |
This is not documented. |
Is the documentation enough then? |
I guess we can go with that for the moment, but if we do have |
Continuation of #117
get_storage
For
get_storage
we can do similarly toget_code_hash
and returnfalse
when an account does not exist, but this is very artificial case, because theget_storage
is only used for the currently executed account. Any VM should not expectget_storage
to fail.set_storage
Similar story as for
get_storage
but worse. Theset_storage
returnsevmc_storage_status
. This one would need to be extended withEVMC_STORAGE_NO_SUCH_ACCOUNT
.The text was updated successfully, but these errors were encountered: