updating markdown text handling, isolated text styles [fixes #858 #832] #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samajammin
suggested changes
Mar 21, 2020
carlfairclough
force-pushed
the
markdown-text-heading-handling
branch
from
eef0f53
to
08239a4
Compare
samajammin
reviewed
Mar 25, 2020
| } | ||
| r.paragraph_open = (tokens, idx, options, env, slf) => | ||
| buildTag(tokens[idx], slf, 'l7 tc-text300') | ||
| r.paragraph_close = () => '</p>' |
There was a problem hiding this comment.
Why do you need to close the paragraph but nothing else?
There was a problem hiding this comment.
For some reason , not including the close tag will mean it doesn't render. Super weird little bug, I should probably report it to markdown-it
samajammin
approved these changes
Mar 25, 2020
This was referenced Mar 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update markdown handling & reduce specificity of markdown styles.
Description
This replaces the way that headings are being handled in markdown, and moves to one layer of css specificity for markdown-generated content. In the current format, text styles are sometimes applied to child elements inside components.
This also means that the existing permalink handling has been replaced (resolving #832) and that the permalink targets have padding (resolving #858)
Related Issue
#832 #858