Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers are hidden when navigating to anchor links #832

Closed
samajammin opened this issue Mar 17, 2020 · 3 comments
Closed

Headers are hidden when navigating to anchor links #832

samajammin opened this issue Mar 17, 2020 · 3 comments
Labels
bug 🐛 Something isn't working

Comments

@samajammin
Copy link
Member

Describe the bug

Looks to be a regression of #292

When navigating to a page section via an anchor link, the nav covers the header.

To Reproduce

Expected behavior

Header of section should be visible

Screenshots

Desktop (please complete the following information):
All browsers

Smartphone (please complete the following information):
All browsers

Additional context

Not sure if this was introduced in #801 or #794
@samajammin samajammin added the bug 🐛 Something isn't working label Mar 17, 2020
@samajammin
Copy link
Member Author

FYI @carlfairclough

@samajammin samajammin mentioned this issue Mar 17, 2020
Closed
34 tasks
@carlfairclough carlfairclough mentioned this issue Mar 18, 2020
Merged
samajammin added a commit that referenced this issue Mar 18, 2020
@samajammin
Merge pull request #841 from carlfairclough/anchor-fix-832
35f8f85 
fix anchor scroll position [fixes #832]
@samajammin
Copy link
Member Author

@carlfairclough looks like there was a regression. I'm seeing this issue again in latest dev: https://share.getcloudapp.com/GGuN5boJ

@samajammin samajammin reopened this Mar 20, 2020
@carlfairclough carlfairclough mentioned this issue Mar 21, 2020
Merged
carlfairclough added a commit to carlfairclough/ethereum-org-website that referenced this issue Mar 23, 2020
@carlfairclough
updating markdown text handling, isolated text styles [fixes ethereum…
18cb3bc 
…#858 ethereum#832]
samajammin added a commit that referenced this issue Mar 25, 2020
@samajammin
Merge pull request #859 from carlfairclough/markdown-text-heading-han…
834d418 
…dling

updating markdown text handling, isolated text styles [fixes #858 #832]
@samajammin
Copy link
Member Author

This was solved in #859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samajammin