i18n: translation pipeline (all languages)#18278
Merged
Merged
Conversation
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
Co-Authored-By: Gemini <gemini@google.com>
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
translation 🌍
Contributor
|
🌐 Translation review started. View progress |
Targeted cleanups from ETHGlossary-grounded translation review of PR #18278: - es page-what-is-the-ethereum-network gas-section-description-6: <beaconchain></beaconchain> tag was empty (visible text placed outside), so the link rendered with no clickable label. Moved "se han quemado" inside the tag to match the pattern used in cs/de/fr/it/pt-br. - sw page-what-is-ether who-holds-most-description-5: stray English "by" in "inayoendeshwa by mabadilishano" -> "na". - zh page-staking-faq-1-answer: stray English "A " at start of answer; Chinese doesn't need the article. - tr page-staking-guide-description-mac-linux-windows: "MacOS" -> "macOS" per ETHGlossary script_rule. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
myelinated-wackerow
approved these changes
May 26, 2026
Collaborator
myelinated-wackerow
left a comment
myelinated-wackerow
left a comment
There was a problem hiding this comment.
Translation Quality Review
PR: #18278
Branch HEAD: af95dd9d29
Languages: 24 (ar, bn, cs, de, es, fr, hi, id, it, ja, ko, mr, pl, pt-br, ru, sw, ta, te, tr, uk, ur, vi, zh, zh-tw)
Files reviewed: 120 JSON files (5 pages × 24 languages): page-staking, page-what-is-ether, page-what-is-the-ethereum-network, page-wallets, page-upgrades
Scope: Full PR diff, ETHGlossary-driven review (per-language /filter lookups, 83+ glossary terms applicable to page-staking alone)
Date: 2026-05-26
Fixes: 4 issues found and fixed in commit af95dd9d29 (es critical + sw/zh/tr cleanup)
Summary
24 parallel script-family-grouped sub-agents reviewed all 120 translated JSON files against pre-fetched ETHGlossary terms for each language. Methodology emphasized ETHGlossary as the authoritative source -- agents were explicitly briefed on the false-positive patterns from the prior PR 18273 review (transliterations matching glossary entries, context-specific Ethereum spellings in Tamil, Geth-stays-Latin policy in Ukrainian, etc.).
Net result: 1 critical UX bug (Spanish) + 3 minor cleanup items found and fixed. Zero remaining critical issues across all 24 languages.
Summary by Language
| Language | Files | Quality | Issues (before fixes) | Status after af95dd9d29 |
|---|---|---|---|---|
| ar | 5 | 8.8/10 | 0 critical, minor warnings | Clean |
| bn | 5 | 9.6/10 | 0 critical | Clean |
| cs | 5 | 9.8/10 | 0 critical | Clean |
| de | 5 | 9.0/10 | 0 critical, register-split warning | Warning open (see below) |
| es | 5 | 8.4/10 -> 9.4/10 | 1 critical, register-split warning | Critical fixed; register warning open |
| fr | 5 | 10.0/10 | 0 critical | Clean |
| hi | 5 | 9.4/10 | 0 critical, parenthetical-gloss style | Warning open |
| id | 5 | 9.8/10 | 0 critical, minor wording | Warning open |
| it | 5 | 9.8/10 | 0 critical | Clean |
| ja | 5 | 9.8/10 | 0 critical | Clean |
| ko | 5 | 9.7/10 | 0 critical | Clean |
| mr | 5 | 9.2/10 | 0 critical, minor consistency | Warning open |
| pl | 5 | 9.8/10 | 0 critical (ZKsync is upstream-side) |
Clean |
| pt-br | 5 | 9.8/10 | 0 critical (ZKsync is upstream-side) |
Clean |
| ru | 5 | 9.8/10 | 0 critical | Clean |
| sw | 5 | 9.2/10 -> 9.4/10 | 0 critical, 1 stray-English + mteja policy |
"by" leak fixed; mteja policy open |
| ta | 5 | 9.4/10 | 0 critical (re-evaluated; context-correct) | Clean |
| te | 5 | 9.8/10 | 0 critical | Clean |
| tr | 5 | 9.7/10 -> 9.8/10 | 0 critical, MacOS casing | MacOS->macOS fixed |
| uk | 5 | 9.8/10 | 0 critical | Clean |
| ur | 5 | 8.6/10 | 0 critical, minor wording | Warning open |
| vi | 5 | 9.4/10 | 0 critical, minor wording | Warning open |
| zh | 5 | 9.8/10 -> 9.8/10 | 0 critical, 1 stray-English | "A" leak fixed |
| zh-tw | 5 | 9.7/10 | 0 critical, gas/燃料 mix | Warning open |
Overall average post-fix: ~9.5/10.
Issues Fixed in This Review (commit af95dd9d29)
| Severity | File | Key | Issue | Fix |
|---|---|---|---|---|
| Critical | src/intl/es/page-what-is-the-ethereum-network.json |
page-what-is-ethereum-network-gas-section-description-6 |
<beaconchain></beaconchain> was empty -- visible link text placed outside the tag, link rendered with no clickable label |
Moved se han quemado inside the tag, matching the pattern used in cs/de/fr/it/pt-br (each wraps the verb form) |
| Cleanup | src/intl/sw/page-what-is-ether.json |
page-what-is-ether-who-holds-most-description-5 |
Stray English by in inayoendeshwa by mabadilishano |
Replaced with Swahili na (passive-agent particle) |
| Cleanup | src/intl/zh/page-staking.json |
page-staking-faq-1-answer |
Stray English A before <em>验证者</em> |
Removed -- Chinese has no indefinite article |
| Cleanup | src/intl/tr/page-staking.json |
page-staking-guide-description-mac-linux-windows |
MacOS deviated from ETHGlossary canonical macOS |
Updated to macOS |
Warnings Open (for native review / future passes)
These are not blocking and are not auto-fixable without a native speaker's judgment.
| Language | Issue | Files |
|---|---|---|
| de | Cross-file register split: page-staking.json uses formal Sie; other 4 use informal du. Site preference is du. |
page-staking vs others |
| es | Cross-file register split: page-staking / page-what-is-ether / page-what-is-the-ethereum-network use usted; page-wallets / page-upgrades use tú. One within-file slip in page-staking-toc-how-to-stake-your-eth. |
3 vs 2 files |
| sw | mteja / wateja used for computing "client". This matches ETHGlossary policy (consensus client -> mteja wa mwafaka) but warrants native Swahili review since mteja primarily means "customer". |
page-staking, page-upgrades |
| vi, id, sw | gas-table-typical-cost-range rendered as "direct cost range" rather than "typical cost range" in all three (shared MT artifact) |
page-what-is-ether |
| hi | page-staking.json adds parenthetical English glosses throughout (e.g., (staking deposit), (validator keys), (self-custody)). Helpful for technical readers but a stylistic choice that should be reviewed for house style. |
page-staking |
| mr | Minor Ethereum Mainnet orthographic drift between इथेरियम मेननेट (descriptive context, lowercase "mainnet" in English) and इथरियम मेननेट (proper noun, capitalized "Mainnet"). The split tracks the English source's capitalization but is subtle. |
page-what-is-ether vs page-what-is-the-ethereum-network |
| zh-tw | gas / Gas / 燃料 mixed renderings within the same file. ETHGlossary acknowledges both forms but consistency within a single file would tighten reading. |
page-what-is-ether, page-what-is-the-ethereum-network |
| ar | Intentional glossary-driven split between staking -> التخزين and staking as a service -> التحصيص كخدمة. Per glossary; flagged only because the dual rendering may surprise readers. |
page-staking |
Upstream Issue (English-side, not a translation deviation)
page-what-is-ethereum-network-layer-2s-section-description-9 references <portal>Portal by ZKsync</portal>. The English source uses capitalization ZKsync while ETHGlossary canonical is zkSync. pl, pt-br, and tr faithfully mirror the English source -- this is not a translation error but worth a one-line fix to the English source in a follow-up.
Methodology Notes
- The slash command's
/filterAPI field was fixed in PR #18275 (text:->content:), so this review's agents actually got authoritative glossary results -- a contributing factor to the much lower false-positive rate compared with the prior PR 18273 review. - Spot-checked PoS / PoW / mainnet / testnet / validator / miner / deposit / withdrawal semantics across all 24 languages. No semantic inversions detected.
- Tamil's three contextual
Ethereumspellings (எத்திரியம்standalone,எத்தீரியம்for Foundation compound,எத்தேரியம்for Mainnet compound) were correctly distinguished per glossary in the relevant keys. - Ukrainian's
Go Ethereum (Geth)correctly stays Latin while sibling client names (Besu, Erigon, Nethermind, Reth, Lighthouse, Lodestar, Nimbus, Teku, Prysm) transliterate to Cyrillic -- 100% glossary-compliant pattern that the PR 18273 review had flagged as a false-positive "inconsistency".
Reviewed by Claude Code with ETHGlossary as authoritative source. 7 parallel script-family-grouped per-language sub-agents, full PR diff scope.
Member
Author
|
ZKsync capitalization fixed with wackerow/ethglossary#1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Translations
This PR contains translations managed by the intl pipeline.
Each run appends a summary below.
Run: 2026-05-26 07:20:02 UTC